Skip to content

docs(answer): sync template standards#324

Merged
mberlofa merged 1 commit into
mainfrom
docs/answer-template-standards-sync
Jul 6, 2026
Merged

docs(answer): sync template standards#324
mberlofa merged 1 commit into
mainfrom
docs/answer-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • register answer in the site sync playground registry
  • keep the playground/site sync gate aligned with the chart validation PR

Validation

  • make site-sync-check CHART=answer
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Chart PR: helmforgedev/charts#644
Issue: helmforgedev/charts#633

Summary by CodeRabbit

  • Bug Fixes
    • Updated playground chart filtering so the “answer” chart is now included in site sync results.
    • Improved the set of charts shown in the playground when syncing site data, helping ensure expected content appears.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 04bcbad8-1e5f-452e-ba35-fee4ecd065e4

📥 Commits

Reviewing files that changed from the base of the PR and between aced120 and 7ff924b.

📒 Files selected for processing (1)
  • src/pages/playground.astro
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/playground.astro

📝 Walkthrough

Walkthrough

A new answer entry was added to siteSyncPlaygroundConfigs in src/pages/playground.astro, extending the chart slugs included in site-sync filtering.

Changes

Playground config mapping update

Layer / File(s) Summary
Add answer key to siteSyncPlaygroundConfigs
src/pages/playground.astro
Added an answer entry mapping to src/data/playground-configs.ts in siteSyncPlaygroundConfigs.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • helmforgedev/site#322: Also updates src/pages/playground.astro to extend siteSyncPlaygroundConfigs with a new chart slug mapping.
  • helmforgedev/site#330: Also changes src/pages/playground.astro by registering a new slug in siteSyncPlaygroundConfigs pointing at src/data/playground-configs.ts.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and refers to the answer sync change, which matches the registry update.
Description check ✅ Passed The description covers the summary and validation, and includes the related chart and issue references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/answer-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@mberlofa mberlofa force-pushed the docs/answer-template-standards-sync branch from 47c0f58 to aced120 Compare July 4, 2026 18:54
mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
## Summary
- add the canonical answer.validate helper and validate.yaml gate
- validate ambiguous database settings, backup settings, ingress hosts,
and selector label overrides
- convert NOTES.txt to numbered operational sections
- make external database and ExternalSecrets CI scenarios self-contained
for k3d

## Validation
- node scripts/charts/template-standards-check.js --chart answer --json
- helm unittest charts/answer
- helm lint --strict charts/answer
- make standards-check CHART=answer
- make validate-chart CHART=answer TIMEOUT=1200: FULLY VALIDATED (18
layers)
- make site-sync-check CHART=answer
- make release-check REPO=charts
- make attribution-check REPO=charts

Site PR: helmforgedev/site#324
Issue: #633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added Helm chart validation to fail fast on common misconfigurations.
  * Improved installation notes with clearer, numbered sections.
* **Bug Fixes**
* Updated CI PostgreSQL connectivity to use a disposable in-cluster
PostgreSQL endpoint with an explicit port.
* Updated external secrets wiring to match the new PostgreSQL endpoint
and added bundled PostgreSQL Service/Deployment manifests for CI.
* Added safeguards for ingress host presence and restricted selector
label overrides.
* **Tests**
* Added validation test cases covering database selection, backup
endpoint, ingress hosts, and pod label constraints.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa force-pushed the docs/answer-template-standards-sync branch from aced120 to 7ff924b Compare July 6, 2026 09:55
@mberlofa mberlofa merged commit 25ed2f5 into main Jul 6, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/answer-template-standards-sync branch July 6, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant